lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err
On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote:
> On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote:
> > From: Laura Lawniczak <laura.lawniczak@googlemail.com>
> []
> > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c
> []
> > @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data *us)
> []
> > - printk(KERN_INFO "MiscReg03 = %x\n", MiscReg03);
> > + dev_info(&us->pusb_dev->dev, "MiscReg03 = %x\n", MiscReg03);
>
> I suggest adding a few convenience macros to make
> this a bit shorter and more likely to fit on a single
> line without exceeding 80 cols.
>
> Adding something like:
>
> #define us_<level>(us, fmt, ...) \
> dev_<level>(&us->pusb_dev->dev, fmt, ##__VA_ARGS__)
>
> so these uses become
>
> us_info(us, "MiscReg03\n", MiscReg03);
>
> which is shorter and more readable.
>

Wait what? That's not a readable example. Why are we passing the
MiscReg03 variable when there is no %d in the string?

You're a big fan of custom printk macros but it's better if people
can stick the to the normal ones if possible. In this case, just
using a local variable is enough:


dev_dbg(us_dev, "scsi cmd %X --- SCSIOP_ALLOW_MEDIUM_REMOVAL\n", cmd);

79 characters.

Anyway this could fixed in a later patch.

regards,
dan carpenter


\
 
 \ /
  Last update: 2013-06-06 23:21    [W:0.080 / U:1.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site