Messages in this thread | | | Date | Wed, 08 May 2013 22:01:01 +0800 | From | Runzhen Wang <> | Subject | Re: [PATCH] perf tools: Fix perf version generation |
| |
On 05/08/2013 07:06 PM, Robert Richter wrote: > On 08.05.13 18:39:07, Xiao Guangrong wrote: I remember that Wang has posted a similar patch to fix this bug several >> weeks ago: http://lkml.org/lkml/2013/4/24/70 >> >> But have no response yet. > > Yes, this patch would fix the version tag too. > > The patch I wrote also reports a commit id even in the case when no > tag is found. This was the original reason why I stumbled over this. > Assume a repository for testing there you just push the commit id to. > This does not contain any tags but a valid commit id. Now, it > determines the version tag from the makefile but does not drop the > commit id. > > -Robert > Hi, Robert,
for http://lkml.org/lkml/2013/4/24/70 I download linux-3.9.1.tar.xz(no git repo) and apply my patch, it works:
# ./perf --version perf version 3.9.1
your patch works when the repo only has commit info but no tags info, but I confuse that whether this situation is Real?
Maybe you prepare for a RARE case but increase the code's **Complexity** ?
thanks
| |