Messages in this thread | | | Date | Wed, 8 May 2013 13:06:11 +0200 | From | Robert Richter <> | Subject | Re: [PATCH] perf tools: Fix perf version generation |
| |
On 08.05.13 18:39:07, Xiao Guangrong wrote: > I remember that Wang has posted a similar patch to fix this bug several > weeks ago: > http://lkml.org/lkml/2013/4/24/70 > > But have no response yet.
Yes, this patch would fix the version tag too.
The patch I wrote also reports a commit id even in the case when no tag is found. This was the original reason why I stumbled over this. Assume a repository for testing there you just push the commit id to. This does not contain any tags but a valid commit id. Now, it determines the version tag from the makefile but does not drop the commit id.
-Robert
| |