Messages in this thread | | | Date | Fri, 10 May 2013 11:09:24 +0200 | From | Robert Richter <> | Subject | Re: [PATCH] perf tools: Fix perf version generation |
| |
On 08.05.13 22:01:01, Runzhen Wang wrote: > # ./perf --version > perf version 3.9.1 > > your patch works when the repo only has commit info but no tags > info, but I confuse that whether this situation is Real? > > Maybe you prepare for a RARE case but increase the code's **Complexity** ?
It works in both cases. And the complexity is also handled for kernel versioning, see scripts/setlocalversion:
# If we don't have a tag at all we print -g{commitish}.
I also considered to reuse scripts/setlocalversion, but it turned out to require too much changes for perf version generation.
-Robert
| |