lkml.org 
[lkml]   [2013]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v6 10/21] sched: get rq potential maximum utilization
On 04/02/2013 05:02 PM, Namhyung Kim wrote:
>> > + cfs_util = (FULL_UTIL - rt_util) > rq->util ? rq->util
>> > + : (FULL_UTIL - rt_util);
>> > + nr_running = rq->nr_running ? rq->nr_running : 1;
> This can be cleaned up with proper min/max().
>
>> > +
>> > + return rt_util + cfs_util * nr_running;
> Should this nr_running consider tasks in cfs_rq only?

use nr_running of cfs_rq seems better, but when use sched autogroup,
only cfs->nr_running just the active group number, not the total active
task number. :(

Also it seems
> there's no upper bound so that it can possibly exceed FULL_UTIL.


--
Thanks Alex


\
 
 \ /
  Last update: 2013-04-03 05:01    [W:0.074 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site