lkml.org 
[lkml]   [2013]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch v6 10/21] sched: get rq potential maximum utilization
On Tue, Apr 2, 2013 at 7:15 PM, Alex Shi <alex.shi@intel.com> wrote:
> On 04/02/2013 05:02 PM, Namhyung Kim wrote:
>>> > + cfs_util = (FULL_UTIL - rt_util) > rq->util ? rq->util
>>> > + : (FULL_UTIL - rt_util);
>>> > + nr_running = rq->nr_running ? rq->nr_running : 1;
>> This can be cleaned up with proper min/max().
>>
>>> > +
>>> > + return rt_util + cfs_util * nr_running;
>> Should this nr_running consider tasks in cfs_rq only?
>
> use nr_running of cfs_rq seems better, but when use sched autogroup,
> only cfs->nr_running just the active group number, not the total active
> task number. :(

Why not just use cfs_rq->h_nr_running? This is always the total
*tasks* in he hierarchy parented that cfs_rq. (This also has the nice property
of not including group_entities.)

>
> Also it seems
>> there's no upper bound so that it can possibly exceed FULL_UTIL.
>
>
> --
> Thanks Alex


\
 
 \ /
  Last update: 2013-04-03 05:01    [W:2.288 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site