lkml.org 
[lkml]   [2013]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v6 10/21] sched: get rq potential maximum utilization

>> + nr_running = rq->nr_running ? rq->nr_running : 1;
>
> This can be cleaned up with proper min/max().

yes, thanks
>
>> +
>> + return rt_util + cfs_util * nr_running;
>
> Should this nr_running consider tasks in cfs_rq only? Also it seems
> there's no upper bound so that it can possibly exceed FULL_UTIL.

Yes.
we need to consider task number:nr_running, otherwise cpu utilization
will never beyond FULL_UTIL, then we can not know if the cpu is overload.
So we need the possible maximum utilization bigger than FULL_UTIL.
>


--
Thanks
Alex


\
 
 \ /
  Last update: 2013-04-02 16:21    [W:0.203 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site