lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] USB: HID: SRW-S1 Add support controlling all LEDs simultaneously
On Thu, 24 Jan 2013, Simon Wood wrote:

> From: simon <simon@simon-virtual-machine.(none)>
>
> This patch to the SRW-S1 driver adds the ability to control all
> LEDs simultaneously as testing showed that it was slow (noticably!!)
> when seting or clearing all the LEDs in turn.
>
> It adds a 'RPMALL' LED, whose behavoir is asserted to all the LEDs in
> the bar graph, individual LEDs can subsequently be turned on/off
> individually.
>
> Signed-off-by: Simon Wood <simon@mungewell.org>
> tested-by: John Murphy <rosegardener@freeode.co.uk>
[ ... snip ... ]

> @@ -219,13 +255,34 @@ static int srws1_probe(struct hid_device *hdev,
>
> /* register led subsystem */
> drv_data->led_state = 0;
> - for (i = 0; i < SRWS1_NUMBER_LEDS; i++)
> + for (i = 0; i < SRWS1_NUMBER_LEDS + 1; i++)
> drv_data->led[i] = NULL;
>
> srws1_set_leds(hdev, 0);
>
> - name_sz = strlen(hdev->uniq) + 15;
> + name_sz = strlen(hdev->uniq) + 16;
> +
> + /* 'ALL', for setting all LEDs simultaneously */
> + led = kzalloc(sizeof(struct led_classdev)+name_sz, GFP_KERNEL);

Is this memory ever freed?

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2013-01-28 16:41    [W:0.080 / U:4.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site