lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] USB: HID: SRW-S1 Gaming Wheel Driver
On Mon, 28 Jan 2013, simon@mungewell.org wrote:

> >> From: simon <simon@simon-virtual-machine.(none)>
> >>
> >> Add support the SRW-S1 by patching HID descriptor to read axis
> >> as Generic Desktop X, Y and Z (rather than Usage page being
> >> 'Simulation').
> >>
> >> Signed-off-by: Simon Wood <simon@mungewell.org>
> >> tested-by: John Murphy <rosegardener@freeode.co.uk>
> >
> > Hi Simon,
> >
> > thanks for the patch.
> >
> >>
> >> ---
> >> drivers/hid/Kconfig | 6 +++++
> >> drivers/hid/Makefile | 1 +
> >> drivers/hid/hid-core.c | 1 +
> >> drivers/hid/hid-ids.h | 3 +++
> >> drivers/hid/hid-srws1.c | 58
> >> +++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Is hid-srws1 really the best name? My understanding is that the vendor is
> > called Steelseries, and we mostly stick to calling the drivers according
> > to the device vendors (and grouping the quirks accordingly).
> >
> > So how about hid-steelseries?
>
> I'm happy to change it; However Steelseries' other devices are all
> keyboards/mice intended for/marketed at gamers. Since other Steelseries
> devices are unlikely to have the same structure (OK I'm just guessing on
> that) is it better to keep this driver somewhat 'seperated'?
>
> I mean, not make life difficult trying to merge keyboard code in with this
> wheel's code.... if that is required in future.

I don't think it's strictly required, but it seems to work quite nicely
for other drivers as well.

Of course, if in the future it turns out that we will need a completely
different driver for some other device produced by this vendor, we can
operatively decide on a different naming for the future.

> If you still would prefer a name change I can do that. In which case is
> the naming of the LED interfaces still OK?
>
> ie.
> --
> echo 1 > /sys/class/leds/SRWS1\:\:69005002125011007452\:\:RPM3/brightness
> --

Yes, that seems fine. Thanks,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2013-01-28 18:41    [W:0.058 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site