Messages in this thread | | | Date | Mon, 16 Jul 2012 12:23:16 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 1/3] mm: correct return value of migrate_pages() |
| |
On Tue, 17 Jul 2012, Joonsoo Kim wrote:
> migrate_pages() should return number of pages not migrated or error code. > When unmap_and_move return -EAGAIN, outer loop is re-execution without > initialising nr_failed. This makes nr_failed over-counted.
The itention of the nr_failed was only to give an indication as to how many attempts where made. The failed pages where on a separate queue that seems to have vanished.
> So this patch correct it by initialising nr_failed in outer loop.
Well yea it makes sense since retry is initialized there as well.
Acked-by: Christoph Lameter <cl@linux.com>
| |