Messages in this thread Patch in this message | | | From | Joonsoo Kim <> | Subject | [PATCH 3/3] mm: fix return value in __alloc_contig_migrate_range() | Date | Tue, 17 Jul 2012 01:14:32 +0900 |
| |
migrate_pages() would return positive value in some failure case, so 'ret > 0 ? 0 : ret' may be wrong. This fix it and remove one dead statement.
Signed-off-by: Joonsoo Kim <js1304@gmail.com> Cc: Michal Nazarewicz <mina86@mina86.com> Cc: Marek Szyprowski <m.szyprowski@samsung.com> Cc: Minchan Kim <minchan@kernel.org> Cc: Christoph Lameter <cl@linux.com>
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 4403009..02d4519 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5673,7 +5673,6 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end) } tries = 0; } else if (++tries == 5) { - ret = ret < 0 ? ret : -EBUSY; break; } @@ -5683,7 +5682,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end) } putback_lru_pages(&cc.migratepages); - return ret > 0 ? 0 : ret; + return ret <= 0 ? ret : -EBUSY; } /* -- 1.7.9.5
| |