Messages in this thread | | | Date | Mon, 16 Jul 2012 12:30:09 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 4] mm: fix possible incorrect return value of move_pages() syscall |
| |
On Tue, 17 Jul 2012, Joonsoo Kim wrote:
> move_pages() syscall may return success in case that > do_move_page_to_node_array return positive value which means migration failed. > This patch changes return value of do_move_page_to_node_array > for not returning positive value. It can fix the problem. > > Signed-off-by: Joonsoo Kim <js1304@gmail.com> > Cc: Brice Goglin <brice@myri.com> > Cc: Christoph Lameter <cl@linux.com> > Cc: Minchan Kim <minchan@kernel.org> > > diff --git a/mm/migrate.c b/mm/migrate.c > index 294d52a..adabaf4 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1171,7 +1171,7 @@ set_status: > } > > up_read(&mm->mmap_sem); > - return err; > + return err > 0 ? -EIO : err; > }
Please use EBUSY.
| |