lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 28/73] net: Dont proxy arp respond if iif == rt->dst.dev if private VLAN is disabled
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Thomas Graf <tgraf@suug.ch>

    [ Upstream commit 70620c46ac2b45c24b0f22002fdf5ddd1f7daf81 ]

    Commit 653241 (net: RFC3069, private VLAN proxy arp support) changed
    the behavior of arp proxy to send arp replies back out on the interface
    the request came in even if the private VLAN feature is disabled.

    Previously we checked rt->dst.dev != skb->dev for in scenarios, when
    proxy arp is enabled on for the netdevice and also when individual proxy
    neighbour entries have been added.

    This patch adds the check back for the pneigh_lookup() scenario.

    Signed-off-by: Thomas Graf <tgraf@suug.ch>
    Acked-by: Jesper Dangaard Brouer <hawk@comx.dk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/arp.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/ipv4/arp.c
    +++ b/net/ipv4/arp.c
    @@ -906,7 +906,8 @@ static int arp_process(struct sk_buff *s
    if (addr_type == RTN_UNICAST &&
    (arp_fwd_proxy(in_dev, dev, rt) ||
    arp_fwd_pvlan(in_dev, dev, rt, sip, tip) ||
    - pneigh_lookup(&arp_tbl, net, &tip, dev, 0))) {
    + (rt->dst.dev != dev &&
    + pneigh_lookup(&arp_tbl, net, &tip, dev, 0)))) {
    n = neigh_event_ns(&arp_tbl, sha, &sip, dev);
    if (n)
    neigh_release(n);



    \
     
     \ /
      Last update: 2012-02-28 02:09    [W:0.042 / U:30.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site