lkml.org 
[lkml]   [2011]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 0/8] Having perf use libparsevent.a
On Fri, Aug 05, 2011 at 09:01:28PM -0400, Steven Rostedt wrote:
> On Fri, 2011-08-05 at 23:24 +0200, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > By keeping the code separate from perf, made the transition from
> > > trace-cmd to tools much easier. I've wasted too many days trying to
> > > get other ways working, and I don't want to rewrite perf to do so.
> >
> > But we want to move tools together, not further apart. Every code
> > activity i see from you is trying to tear apart instrumentation
>
> Ouch!
>
> Ingo, I was trying to do as you said, but to do so would require a lot
> of restructuring of the perf code base. I started talking with Arnaldo,
> as he's doing a lot of the work in the tools/perf code, and he's the one
> that suggested that I do it this way. It made things a lot easier.
>
> Seriously, I wasted Mon-Wed trying to see how it would work in
> tools/perf. I went through iteration after iteration, and each time I
> either rewrote the tools/perf/Makefile, or hacked apart the libparsevent
> code to be strictly perf specific, and not very useful for anything
> else.

Now you feel exactly how I felt when preparing the RAS daemon stuff :-)

I think we should first agree on the design of libperf or whatever other
libraries and then start working towards it. Then we'd all know where
we're going so coding it up would be almost a routine task. And then,
other people who've done it for a couple of times already (hint: me)
could help so Steve won't have to do it alone.

Thanks.

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2011-08-06 11:17    [W:3.022 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site