lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 0/8] Having perf use libparsevent.a
From
Date
On Sat, 2011-08-06 at 08:51 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > Ingo, I was trying to do as you said, but to do so would require a
> > lot of restructuring of the perf code base. I started talking with
> > Arnaldo, as he's doing a lot of the work in the tools/perf code,
> > and he's the one that suggested that I do it this way. It made
> > things a lot easier.
>
> Could you guys please talk some more and clear it up? There's
> absolutely no technical reason why tools/perf/lib/ (or
> tools/perf/libperf/) should be harder than tools/lib/.

The issue was trying to use the Makefile within perf for the building.
There was issues with the warning flags and also the deps that are
automatically made with libparsevent.

But you are correct, if I were to just move the pointers over to
tools/perf/lib/events instead of tools/lib/events and had it be a
separate entity in the build process, then it would not be any different
between the two locations.

But there are two non-technical issues with that. Is it wise to have a
different type of build process within the tools/perf directory. The
libparsevents follows the Linux build system more than the git build
system.
The other being, is the parse events a perf only thing? Maybe having a
tools/lib would be nice even if it is. Because we can put things in
tools/lib that will go as a separate package. perf could depend on
tools/lib but there's no reason that tools/lib should depend on perf.

-- Steve




\
 
 \ /
  Last update: 2011-08-08 23:33    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean