lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig'
    From
    Date
    On Mon, 2011-05-30 at 09:23 +0200, Ingo Molnar wrote:
    > You thoroughly misunderstood my prior regression report, the problem
    > with your patch was that your patch actually *broke* existing
    > filtered-randconfig behavior, for example trying to get a 64-bit
    > randconfig:
    >
    > make ARCH=x86_64 randconfig
    >
    > ... will today produce a 64-bit randconfig while with your old change
    > applied it produced a 32-bit randconfig 50% of the time.

    I believe that this 'filtered randconfig' behaviour is now fairly much
    the *only* use for the old 'ARCH=i386' and 'ARCH=x86_64'.

    Other than that, we ought to finally be able to 'complete' the merge of
    32-bit and 64-bit support into ARCH=x86, and remove the last traces of
    the obsolete ARCH={i386,x86_64} settings completely? Just as we did for
    'ARCH=ppc{64,}' a few years ago.

    And as I said, it's still an incomplete solution if you actually want a
    'filtered randconfig' to do anything *useful*. You'd be much better off
    implementing a *real* filtered randconfig that allows you to give a list
    of hard-coded options, rather than relying on a dirty hack that only
    actually sets *one* option of the many that you might need to
    'hard-code' if you actually wanted a useful build.

    So no, I don't think I misunderstood your "regression report" at all.

    But go ahead and change the commit message if you must. As long as the
    bug gets fixed, I'm content.

    --
    dwmw2



    \
     
     \ /
      Last update: 2011-05-30 10:59    [W:0.024 / U:61.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site