lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig'

* David Woodhouse <dwmw2@infradead.org> wrote:

> On Mon, 2011-05-30 at 09:23 +0200, Ingo Molnar wrote:
> > You thoroughly misunderstood my prior regression report, the problem
> > with your patch was that your patch actually *broke* existing
> > filtered-randconfig behavior, for example trying to get a 64-bit
> > randconfig:
> >
> > make ARCH=x86_64 randconfig
> >
> > ... will today produce a 64-bit randconfig while with your old change
> > applied it produced a 32-bit randconfig 50% of the time.
>
> I believe that this 'filtered randconfig' behaviour is now fairly much
> the *only* use for the old 'ARCH=i386' and 'ARCH=x86_64'.

Not really, there's also:

make ARCH=i386 defconfig # writes 32-bit defconfig into .config
make ARCH=x86_64 defconfig # writes 64-bit defconfig into .config

make ARCH=i386 oldconfig # turns 64-bit .config int 32-bit equivalent
make ARCH=x86_64 oldconfig # turns 32-bit .config int 64-bit equivalent

And i use these variants myself, both as commands typed and in
scripts, in addition to the randconfig variants:

make ARCH=i386 randconfig # write 32-bit randconfig into .config
make ARCH=x86_64 randconfig # write 64-bit randconfig into .config

I'm pretty sure others are relying on these variants as well - they
are fairly logical along several dimensions.

So could we please fix the 'make oldconfig' behavior (which i fully
agree with you should pick up the bitness from the .config) *without*
regressing these other, working and useful cases?

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-30 12:45    [W:0.131 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site