Messages in this thread | | | From | Con Kolivas <> | Subject | question about blk_schedule_flush_plug | Date | Mon, 23 May 2011 17:05:19 +1000 |
| |
I was looking at the scheduler changes going into 2.6.39 again and wondered about the use of blk_schedule_flush_plug smack in the middle of schedule()
It looks like this: if (blk_needs_flush_plug(prev)) { raw_spin_unlock(&rq->lock); blk_schedule_flush_plug(prev); raw_spin_lock(&rq->lock); }
Now call me suspicious but to my eyes it looks really dubious unlocking the runqueue like that right in the heart of schedule().
Comments?
Thanks, Con -- -ck
| |