lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectquestion about blk_schedule_flush_plug
Date
I was looking at the scheduler changes going into 2.6.39 again and wondered 
about the use of blk_schedule_flush_plug smack in the middle of schedule()

It looks like this:
if (blk_needs_flush_plug(prev)) {
raw_spin_unlock(&rq->lock);
blk_schedule_flush_plug(prev);
raw_spin_lock(&rq->lock);
}

Now call me suspicious but to my eyes it looks really dubious unlocking the
runqueue like that right in the heart of schedule().

Comments?

Thanks,
Con
--
-ck


\
 
 \ /
  Last update: 2011-05-23 09:07    [W:0.034 / U:17.396 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site