[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: question about blk_schedule_flush_plug
On Mon, 2011-05-23 at 17:05 +1000, Con Kolivas wrote:
> I was looking at the scheduler changes going into 2.6.39 again and wondered
> about the use of blk_schedule_flush_plug smack in the middle of schedule()
> It looks like this:
> if (blk_needs_flush_plug(prev)) {
> raw_spin_unlock(&rq->lock);
> blk_schedule_flush_plug(prev);
> raw_spin_lock(&rq->lock);
> }
> Now call me suspicious but to my eyes it looks really dubious unlocking the
> runqueue like that right in the heart of schedule().
> Comments?

Yeah, that's quite all-right, both pre_schedule() and idle_balance()
already did that too.

We can safely release the runqueue lock after deactivate_task() and
before put_prev_task().

 \ /
  Last update: 2011-05-23 09:39    [W:0.036 / U:7.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site