Messages in this thread Patch in this message | | | Date | Thu, 19 May 2011 21:27:03 +0300 | From | Maxin B John <> | Subject | [PATCH] drivers: video: Remove useless checks |
| |
Comparing unsigned less than zero will never be true. Removing similar checks from 'fbmem.c' and 'fbcmap.c'.
Please let me know your comments.
Signed-off-by: Maxin B. John <maxin.john@gmail.com> --- diff --git a/drivers/video/fbcmap.c b/drivers/video/fbcmap.c index 5c3960d..15cf8fc 100644 --- a/drivers/video/fbcmap.c +++ b/drivers/video/fbcmap.c @@ -285,8 +285,7 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info) rc = -ENODEV; goto out; } - if (cmap->start < 0 || (!info->fbops->fb_setcolreg && - !info->fbops->fb_setcmap)) { + if (!info->fbops->fb_setcolreg && !info->fbops->fb_setcmap) { rc = -EINVAL; goto out1; } diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 5aac00e..9edca4d 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -1143,7 +1143,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, return -EFAULT; if (con2fb.console < 1 || con2fb.console > MAX_NR_CONSOLES) return -EINVAL; - if (con2fb.framebuffer < 0 || con2fb.framebuffer >= FB_MAX) + if (con2fb.framebuffer >= FB_MAX) return -EINVAL; if (!registered_fb[con2fb.framebuffer]) request_module("fb%d", con2fb.framebuffer);
| |