lkml.org 
[lkml]   [2011]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] drivers: video: Remove useless checks
    From
    ping ...

    On Thu, May 19, 2011 at 7:27 PM, Maxin B John <maxin.john@gmail.com> wrote:
    > Comparing unsigned less than zero will never be true.
    > Removing similar checks from 'fbmem.c' and 'fbcmap.c'.
    >
    > Please let me know your comments.
    >
    > Signed-off-by: Maxin B. John <maxin.john@gmail.com>
    > ---
    > diff --git a/drivers/video/fbcmap.c b/drivers/video/fbcmap.c
    > index 5c3960d..15cf8fc 100644
    > --- a/drivers/video/fbcmap.c
    > +++ b/drivers/video/fbcmap.c
    > @@ -285,8 +285,7 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info)
    >                rc = -ENODEV;
    >                goto out;
    >        }
    > -       if (cmap->start < 0 || (!info->fbops->fb_setcolreg &&
    > -                               !info->fbops->fb_setcmap)) {
    > +       if (!info->fbops->fb_setcolreg && !info->fbops->fb_setcmap) {
    >                rc = -EINVAL;
    >                goto out1;
    >        }
    > diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
    > index 5aac00e..9edca4d 100644
    > --- a/drivers/video/fbmem.c
    > +++ b/drivers/video/fbmem.c
    > @@ -1143,7 +1143,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd,
    >                        return -EFAULT;
    >                if (con2fb.console < 1 || con2fb.console > MAX_NR_CONSOLES)
    >                        return -EINVAL;
    > -               if (con2fb.framebuffer < 0 || con2fb.framebuffer >= FB_MAX)
    > +               if (con2fb.framebuffer >= FB_MAX)
    >                        return -EINVAL;
    >                if (!registered_fb[con2fb.framebuffer])
    >                        request_module("fb%d", con2fb.framebuffer);
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-03 11:31    [W:0.024 / U:0.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site