| From | Andi Kleen <> | Subject | [PATCH] [80/106] Input: synaptics - fix crash in synaptics_module_init() | Date | Tue, 26 Apr 2011 14:14:01 -0700 (PDT) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Jan Beulich <JBeulich@novell.com>
[ upstream commit 708748670c7c6dd5bd3b141473086e6937e72737 ]
'struct dmi_system_id' arrays must always have a terminator to keep dmi_check_system() from looking at data (and possibly crashing) it isn't supposed to look at.
The issue went unnoticed until ef8313bb1a22e7d2125d9d758aa8a81f1de91d81, but was introduced about a year earlier with 7705d548cbe33f18ea7713b9a07aa11047aaeca4 (which also similarly changed lifebook.c, but the problem there got eliminated shortly afterwards).
The first hunk therefore is a stable candidate back to 2.6.33, while the full change is needed only on 2.6.38.
Signed-off-by: Jan Beulich <jbeulich@novell.com> Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: stable@kernel.org Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Index: linux-2.6.35.y/drivers/input/mouse/synaptics.c =================================================================== --- linux-2.6.35.y.orig/drivers/input/mouse/synaptics.c +++ linux-2.6.35.y/drivers/input/mouse/synaptics.c @@ -712,8 +712,8 @@ static const struct dmi_system_id __init }, }, - { } #endif + { } }; void __init synaptics_module_init(void)
|