lkml.org 
[lkml]   [2011]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [9/106] irda: validate peer name and attribute lengths
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Dan Rosenberg <drosenberg@vsecurity.com>

    commit d370af0ef7951188daeb15bae75db7ba57c67846 upstream.

    Length fields provided by a peer for names and attributes may be longer
    than the destination array sizes. Validate lengths to prevent stack
    buffer overflows.

    Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    net/irda/iriap.c | 6 ++++++
    1 file changed, 6 insertions(+)

    Index: linux-2.6.35.y/net/irda/iriap.c
    ===================================================================
    --- linux-2.6.35.y.orig/net/irda/iriap.c
    +++ linux-2.6.35.y/net/irda/iriap.c
    @@ -656,10 +656,16 @@ static void iriap_getvaluebyclass_indica
    n = 1;

    name_len = fp[n++];
    +
    + IRDA_ASSERT(name_len < IAS_MAX_CLASSNAME + 1, return;);
    +
    memcpy(name, fp+n, name_len); n+=name_len;
    name[name_len] = '\0';

    attr_len = fp[n++];
    +
    + IRDA_ASSERT(attr_len < IAS_MAX_ATTRIBNAME + 1, return;);
    +
    memcpy(attr, fp+n, attr_len); n+=attr_len;
    attr[attr_len] = '\0';


    \
     
     \ /
      Last update: 2011-04-26 23:43    [W:0.020 / U:59.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site