| From | Andi Kleen <> | Subject | [PATCH] [24/106] Bluetooth: sco: fix information leak to userspace | Date | Tue, 26 Apr 2011 14:13:02 -0700 (PDT) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Vasiliy Kulikov <segoon@openwall.com>
commit c4c896e1471aec3b004a693c689f60be3b17ac86 upstream.
struct sco_conninfo has one padding byte in the end. Local variable cinfo of type sco_conninfo is copied to userspace with this uninizialized one byte, leading to old stack contents leak.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- net/bluetooth/sco.c | 1 + 1 file changed, 1 insertion(+)
Index: linux-2.6.35.y/net/bluetooth/sco.c =================================================================== --- linux-2.6.35.y.orig/net/bluetooth/sco.c +++ linux-2.6.35.y/net/bluetooth/sco.c @@ -700,6 +700,7 @@ static int sco_sock_getsockopt_old(struc break; } + memset(&cinfo, 0, sizeof(cinfo)); cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle; memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);
|