lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] pata_sil680: minor CodingStyle fixups
Hello.

On 11-10-2011 22:21, Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] pata_sil680: minor CodingStyle fixups

> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
> drivers/ata/pata_sil680.c | 58 ++++++++++++++++++++++++++--------------------
> 1 file changed, 33 insertions(+), 25 deletions(-)

> Index: b/drivers/ata/pata_sil680.c
> ===================================================================
> --- a/drivers/ata/pata_sil680.c
> +++ b/drivers/ata/pata_sil680.c
[...]
> @@ -265,12 +266,19 @@ static u8 sil680_init_chip(struct pci_de
> pci_write_config_dword(pdev, 0xB8, 0x43924392);
> pci_write_config_dword(pdev, 0xBC, 0x40094009);
>
> - switch(tmpbyte& 0x30) {
> - case 0x00: printk(KERN_INFO "sil680: 100MHz clock.\n");break;
> - case 0x10: printk(KERN_INFO "sil680: 133MHz clock.\n");break;
> - case 0x20: printk(KERN_INFO "sil680: Using PCI clock.\n");break;
> - /* This last case is _NOT_ ok */
> - case 0x30: printk(KERN_ERR "sil680: Clock disabled ?\n");
> + switch (tmpbyte& 0x30) {
> + case 0x00:
> + printk(KERN_INFO "sil680: 100MHz clock.\n");
> + break;
> + case 0x10:
> + printk(KERN_INFO "sil680: 133MHz clock.\n");
> + break;
> + case 0x20:
> + printk(KERN_INFO "sil680: Using PCI clock.\n");
> + break;

pr_info() here and above?

> + /* This last case is _NOT_ ok */
> + case 0x30:
> + printk(KERN_ERR "sil680: Clock disabled ?\n");

pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?

WBR, Sergei


\
 
 \ /
  Last update: 2011-10-12 12:51    [W:0.060 / U:9.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site