lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] pata_sil680: minor CodingStyle fixups

>
> > + /* This last case is _NOT_ ok */
> > + case 0x30:
> > + printk(KERN_ERR "sil680: Clock disabled ?\n");
>
> pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?

dev_ would be even better but that seems to be a separate thing. The
existing patch is still a move in the right direction.


\
 
 \ /
  Last update: 2011-10-12 13:05    [W:0.062 / U:1.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site