lkml.org 
[lkml]   [2011]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] pata_sil680: minor CodingStyle fixups
On 10/12/2011 07:03 AM, Alan Cox wrote:
>
>>
>>> + /* This last case is _NOT_ ok */
>>> + case 0x30:
>>> + printk(KERN_ERR "sil680: Clock disabled ?\n");
>>
>> pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?
>
> dev_ would be even better but that seems to be a separate thing. The
> existing patch is still a move in the right direction.

agreed x 2

To be specific, it should be

dev_err(&pdev->dev



\
 
 \ /
  Last update: 2011-10-14 18:47    [W:0.639 / U:4.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site