| Subject | Re: [PATCH 1/2] jump label: make enable/disable o(1) | From | Steven Rostedt <> | Date | Wed, 05 Jan 2011 12:31:05 -0500 |
| |
On Wed, 2011-01-05 at 10:43 -0500, Jason Baron wrote: > > +struct jump_label_key { > + int state; > +}; > + > #define JUMP_LABEL(key, label) \ > do { \ > - if (unlikely(*key)) \ > + if (unlikely(((struct jump_label_key *)key)->state)) \ > goto label; \ > } while (0)
Anything that uses JUMP_LABEL() should pass in a pointer to a struct jump_label_key. Hence, remove the typecast. That can only lead to hard to find bugs.
-- Steve
|