lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/2] jump label: 2.6.38 updates

    * Peter Zijlstra <peterz@infradead.org> wrote:

    > On Fri, 2011-02-11 at 22:38 +0100, Peter Zijlstra wrote:
    > >
    > > So why can't we make that jump_label_entry::refcount and
    > > jump_label_key::state an atomic_t and be done with it?
    >
    > So I had a bit of a poke at this because I didn't quite understand why
    > all that stuff was as it was. I applied both Jason's patches and then
    > basically rewrote kernel/jump_label.c just for kicks ;-)
    >
    > I haven't tried compiling this, let alone running it, but provided I
    > didn't actually forget anything the storage per key is now 16 bytes when
    > modules are disabled and 24 * (1 + mods) bytes for when they are
    > enabled. The old code had 64 + 40 * mods bytes.
    >
    > I still need to clean up the static_branch_else bits and look at !x86
    > aside from the already mentioned bits.. but what do people think?

    [...]

    > 15 files changed, 333 insertions(+), 456 deletions(-)

    The diffstat win alone makes me want this :-)

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-02-14 13:31    [W:5.555 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site