lkml.org 
[lkml]   [2011]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/18] frv: switch do_timer() to xtime_update()
    Date
    this code looks like its protecting __set_LEDS() with this lock also.
    i dont think thats necessary.

    Signed-off-by: Torben Hohn <torbenh@gmx.de>
    ---
    arch/frv/kernel/time.c | 9 ++++-----
    1 files changed, 4 insertions(+), 5 deletions(-)

    diff --git a/arch/frv/kernel/time.c b/arch/frv/kernel/time.c
    index 0ddbbae..0d95162 100644
    --- a/arch/frv/kernel/time.c
    +++ b/arch/frv/kernel/time.c
    @@ -50,7 +50,7 @@ static struct irqaction timer_irq = {

    /*
    * timer_interrupt() needs to keep up the real-time clock,
    - * as well as call the "do_timer()" routine every clocktick
    + * as well as call the "xtime_update()" routine every clocktick
    */
    static irqreturn_t timer_interrupt(int irq, void *dummy)
    {
    @@ -61,10 +61,11 @@ static irqreturn_t timer_interrupt(int irq, void *dummy)
    * CPU. We need to avoid to SMP race with it. NOTE: we don't need
    * the irq version of write_lock because as just said we have irq
    * locally disabled. -arca
    + *
    + * xtime_update takes the writelock.
    */
    - write_seqlock(&xtime_lock);

    - do_timer(1);
    + xtime_update(1);

    #ifdef CONFIG_HEARTBEAT
    static unsigned short n;
    @@ -72,8 +73,6 @@ static irqreturn_t timer_interrupt(int irq, void *dummy)
    __set_LEDS(n);
    #endif /* CONFIG_HEARTBEAT */

    - write_sequnlock(&xtime_lock);
    -
    update_process_times(user_mode(get_irq_regs()));

    return IRQ_HANDLED;
    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-01-22 00:09    [W:0.020 / U:92.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site