Messages in this thread | | | Date | Mon, 24 Jan 2011 14:09:24 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 09/18] frv: switch do_timer() to xtime_update() |
| |
On Mon, 24 Jan 2011, torbenh wrote: > On Sat, Jan 22, 2011 at 11:01:49AM +0100, Thomas Gleixner wrote: > > On Sat, 22 Jan 2011, Torben Hohn wrote: > > > > > this code looks like its protecting __set_LEDS() with this lock also. > > > i dont think thats necessary. > > > > This changelog is horrible. > > agreed. > what i meant was that: if i do something while holding a lock, > it seems to be necessary to do it while holding the lock.
Well, it might be that way, but obviously that's not the case with the code which is in the xtime lock write locked region (except for the do_timer() call). :)
> > Also all arch/* patches are missing a "Cc: arch-maintainer@somewhere.xxx". > > i was planning to send it out with --cc-cmd=./scripts/get_maintainers.pl > once you thought it was ok. > is that procedure ok ?
get_maintainers creates ugly long cc lists. I prefer hand selected cc's. For the arch specific changes cc'ing only the relevant maintainer (retrieved from MAINTAINERS) is enough.
> or should i add CC: lines to the commitlogs ?
Either way works. If I pick up such a series, my scripts generate the Cc list in the changelog from the mail CC list.
Thanks,
tglx
| |