lkml.org 
[lkml]   [2010]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory
On Thu, 16 Sep 2010 12:52:40 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 2010-09-16 at 18:07 +0100, Alan Cox wrote:
> > ->tiocmget;
> > > >
> > > > + memset(&icount, 0, sizeof(struct serial_icounter_struct));
> > > > +
> > >
> > > Move the above to after the spinlocks.
> >
> > Why - its a local variable ?
> >
> > Easier to write
> >
> > struct serial_icounter_struct icount = { 0 };
> >
> > though
>
> True, but if we want to micro-optimize, moving it after the spinlocks
> means we do no zero initialization in the tiocmget == 0. Although gcc
> may be smart enough to realize that too.

If you want to micro-optimise it you can enumerate the cases that
tiocmget can be NULL in that driver..


\
 
 \ /
  Last update: 2010-09-16 19:29    [W:0.034 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site