->tiocmget;> > > > + memset(&icount, 0, sizeof(struct serial_icounter_struct));> > +> > Move the above to after the spinlocks.Why - its a local variable ?Easier to write struct serial_icounter_struct icount = { 0 };though