lkml.org 
[lkml]   [2010]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory
From
Date
On Thu, 2010-09-16 at 18:07 +0100, Alan Cox wrote:
> ->tiocmget;
> > >
> > > + memset(&icount, 0, sizeof(struct serial_icounter_struct));
> > > +
> >
> > Move the above to after the spinlocks.
>
> Why - its a local variable ?
>
> Easier to write
>
> struct serial_icounter_struct icount = { 0 };
>
> though

True, but if we want to micro-optimize, moving it after the spinlocks
means we do no zero initialization in the tiocmget == 0. Although gcc
may be smart enough to realize that too.

-- Steve




\
 
 \ /
  Last update: 2010-09-16 18:55    [W:0.087 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site