lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [regression] Crash in wb_clear_pending()
On Tue, Jul 06, 2010 at 08:47:33AM +0200, Ingo Molnar wrote:
> Yeah, i agree - especially since the smaller patch is still pretty large (not
> a oneliner), plus it does not appear that the precise failure mode is fully
> understood either.

The two failure modes we saw are very precicely understood:

- access to ->state after it's been freed
- access to ->state after the caller which has the bdi_work struct on
stack has been woken up.

But I seriously fear that there are even more dragons hidden in this
maze of bit wakeups and rcu, so replacing it with a proper completion
seems by far safer to me.



\
 
 \ /
  Last update: 2010-07-07 03:49    [W:0.075 / U:4.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site