lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [regression] Crash in wb_clear_pending()

* Jens Axboe <axboe@kernel.dk> wrote:

> On 2010-07-06 08:47, Ingo Molnar wrote:
> >
> > * Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> >> On Mon, Jul 5, 2010 at 2:19 PM, Bill Davidsen <davidsen@tmr.com> wrote:
> >>>
> >>> Absent a small fix, and given that the big fix has a lot more testing than
> >>> any new patch might, in this case the quickie might be undesirable.
> >>> Particularly since posters here seem sure that code will be replaced in the
> >>> next version anyway, and lightly tested patch to obsolete code is actually
> >>> less conservative.
> >>
> >> I have to agree. Especially as the "big patch" just removes the fragile code
> >> that caused the problem in the first place. So in this case I do suspect
> >> that the bigger patch ends up being the safer one.
> >
> > Yeah, i agree - especially since the smaller patch is still pretty large (not
> > a oneliner), plus it does not appear that the precise failure mode is fully
> > understood either.
>
> http://lkml.org/lkml/2010/7/5/232
>
> It's about as straight forward as it can be :-)

Yeah, i meant Christoph's first patch. Yours looks simple enough but from the
discussion it wasnt clear (to me) yet whether it would fix the bug.

Thanks,

Ingo


\
 
 \ /
  Last update: 2010-07-06 08:59    [W:0.049 / U:4.868 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site