Messages in this thread | | | Date | Tue, 06 Jul 2010 08:25:46 +0200 | From | Jens Axboe <> | Subject | Re: [regression] Crash in wb_clear_pending() |
| |
On 2010-07-06 01:34, Linus Torvalds wrote: > On Mon, Jul 5, 2010 at 2:19 PM, Bill Davidsen <davidsen@tmr.com> wrote: >> >> Absent a small fix, and given that the big fix has a lot more testing than >> any new patch might, in this case the quickie might be undesirable. >> Particularly since posters here seem sure that code will be replaced in the >> next version anyway, and lightly tested patch to obsolete code is actually >> less conservative. > > I have to agree. Especially as the "big patch" just removes the > fragile code that caused the problem in the first place. So in this > case I do suspect that the bigger patch ends up being the safer one.
OK, it's up to you.
> But I obviously don't actually see the problem, so it would be good to > get confirmation that Christoph's patch actually fixes things first. > Ingo, does the one in this thread apply for you?
I'll update for-linus, Ingo can try that.
-- Jens Axboe
| |