Messages in this thread | | | Date | Tue, 29 Jun 2010 14:42:58 +0200 | From | Dan Carpenter <> | Subject | Re: [PATCH 01/25] r852: remove casts from void* |
| |
On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote: > Remove unnesessary casts from void*. >
1) The subjects are not helpful. This one should say something about "mtd" but it doesn't. 2) These haven't been run through checkpatch.pl. In fact, I can't be certain anyone looked at these patches when I see things like:
- if((( lp = (struct wl_private *)dev->priv ) != NULL ) && - !( lp->flags & WVLAN2_UIL_BUSY )) { + if((( lp = dev->priv ) != NULL ) && + !( lp->flags & WVLAN2_UIL_BUSY )) {
On the recieving end, someone has to review every patch that gets merged.
regards, dan carpenter
| |