lkml.org 
[lkml]   [2010]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/25] r852: remove casts from void*


Dan Carpenter schrieb:
> On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote:
>> Remove unnesessary casts from void*.
>>
>
> 1) The subjects are not helpful. This one should say something about
> "mtd" but it doesn't.
> 2) These haven't been run through checkpatch.pl. In fact, I can't be
> certain anyone looked at these patches when I see things like:
>
> - if((( lp = (struct wl_private *)dev->priv ) != NULL ) &&
> - !( lp->flags & WVLAN2_UIL_BUSY )) {
> + if((( lp = dev->priv ) != NULL ) &&
> + !( lp->flags & WVLAN2_UIL_BUSY )) {
>
> On the recieving end, someone has to review every patch that gets merged.
>


same problem in drivers/scsi/sg.c but that would requiere a additional patch.

re,
wh



\
 
 \ /
  Last update: 2010-06-29 14:59    [W:0.108 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site