Messages in this thread | | | Date | Tue, 29 Jun 2010 21:01:32 +0200 | From | Dan Carpenter <> | Subject | Re: [PATCH 01/25] r852: remove casts from void* |
| |
On Tue, Jun 29, 2010 at 07:28:26PM +0400, Kulikov Vasiliy wrote: > > 1) The subjects are not helpful. This one should say something about > > "mtd" but it doesn't. > ok > > > 2) These haven't been run through checkpatch.pl. > Sorry for dummy question, but shouldn't code style be consistent? > Somebody who will see old code and patched code will see one line with > wrong-style code then one line with ok then one with wrong etc. > Imho it's better to fix style in one big patch.
No. If there's only one good line in a whole file, that's at least better than nothing.
regards, dan carpenter
| |