Messages in this thread | | | Date | Thu, 25 Feb 2010 14:15:58 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH] TOMOYO: Protect find_task_by_vpid() with RCU. |
| |
On Thu, 25 Feb 2010, Tetsuo Handa wrote:
> James Morris wrote: > > On Wed, 24 Feb 2010, Tetsuo Handa wrote: > > > > > Caller of find_task_by_vpid() must use rcu_read_lock(). > > > > The comment for the function says: > > > > Must be called under rcu_read_lock() or with tasklist_lock read-held. > > > > In the cases below, you have taken tasklist_lock. > > That comment will be updated to > "Must be called under rcu_read_lock()." in 2.6.34 . > Please see http://lkml.org/lkml/2009/12/10/180 and http://lkml.org/lkml/2009/12/9/472 .
Ok, please fix the comment as well.
Thomas: wasn't Tetsuo correct that we need both the rcu lock and tasklist_lock held to call this?
Also, I think the audit code needs fixing.
-- James Morris <jmorris@namei.org>
| |