lkml.org 
[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHSET] workqueue: another assorted flush_scheduled_work() removals
Date
Hello,

This is another set of patches to remove flush_scheduled_work() users.

0001-init-don-t-call-flush_scheduled_work-from-do_initcal.patch
0002-ioc4-use-static-work_struct-for-ioc4_load_modules.patch
0003-media-video-explicitly-flush-request_module-work.patch
0004-media-video-don-t-use-flush_scheduled_work.patch
0005-speedtch-don-t-abuse-struct-delayed_work.patch
0006-usb-don-t-use-flush_scheduled_work.patch

Andrew, implementing proper work function in init text test requires
tracking an additional state for each worker. I don't think it'll be
worth the effort or complexity as removal of init sections itself will
make the bugs, if exists, quite visible anyway, so I just updated
patch description of 0001. What do you think?

0002 updates the ioc4 driver to use static work_struct and removes
flush_scheduled_work() call in the process.

0003-0004 convert the video drivers and 0005-0006 usb.

These patches are available in the following git tree.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git net-dev-kill-flush_scheduled_work

Note that the branch is on top of the previous set of
flush_scheduled_work() removal patches; however, they're independent
and this series cleanly applies on top of 2.6.37-rc5
(6313e3c21743cc88bb5bd8aa72948ee1e83937b6).

diffstat follows. Thanks.

drivers/media/video/bt8xx/bttv-driver.c | 9 ++++++++
drivers/media/video/bt8xx/bttv-input.c | 5 ----
drivers/media/video/cx18/cx18-driver.c | 8 +++++++
drivers/media/video/cx231xx/cx231xx-cards.c | 8 +++++++
drivers/media/video/cx23885/cx23885-input.c | 2 -
drivers/media/video/cx88/cx88-mpeg.c | 8 +++++++
drivers/media/video/em28xx/em28xx-cards.c | 8 +++++++
drivers/media/video/omap24xxcam.c | 6 ++---
drivers/media/video/saa7134/saa7134-core.c | 11 ++++++++-
drivers/media/video/saa7134/saa7134-empress.c | 2 -
drivers/misc/ioc4.c | 29 ++++++++------------------
drivers/usb/atm/speedtch.c | 27 ++++++++++++------------
drivers/usb/gadget/u_ether.c | 4 ---
drivers/usb/host/ohci-hcd.c | 3 +-
drivers/usb/otg/isp1301_omap.c | 2 -
drivers/usb/serial/oti6858.c | 5 +---
drivers/video/fb_defio.c | 5 +---
init/main.c | 3 --
18 files changed, 86 insertions(+), 59 deletions(-)

--
tejun


\
 
 \ /
  Last update: 2010-12-12 17:51    [W:0.116 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site