Messages in this thread | | | Date | Fri, 17 Dec 2010 14:51:17 +0100 | From | Nicolas Kaiser <> | Subject | Re: speedtch: don't abuse struct delayed_work |
| |
> On Sun, Dec 12, 2010 at 05:48:18PM +0100, Tejun Heo wrote: >> speedtch directly uses the internal timer and work members of a struct >> delayed_work. Use a separate work item and timer instead.
>> This is part of a series to remove flush_scheduled_work() usage to >> prepare for deprecation of flush_scheduled_work(). Patches in this >> series are self contained and mostly straight-forward
I tested this patch with 2.6.37-rc6. Not sure whether I'm doing something wrong, but I failed to start the PPP daemon with my speedtouch usb:
Dec 17 14:17:24 absol pppd[4853]: Plugin pppoatm.so loaded. Dec 17 14:17:24 absol pppd[4853]: PPPoATM plugin_init Dec 17 14:17:24 absol pppd[4853]: PPPoATM setdevname_pppoatm - SUCCESS:8.48 Dec 17 14:17:24 absol pppd[4854]: pppd 2.4.4 started by root, uid 0 Dec 17 14:17:24 absol pppd[4854]: connect(8.48): No such device Dec 17 14:17:24 absol pppd[4854]: Exit.
Dec 17 14:17:26 absol rc-scripts: Failed to start the PPP daemon
Without the patch:
Dec 17 14:19:19 absol pppd[4847]: Plugin pppoatm.so loaded. Dec 17 14:19:19 absol pppd[4847]: PPPoATM plugin_init Dec 17 14:19:19 absol pppd[4847]: PPPoATM setdevname_pppoatm - SUCCESS:8.48 Dec 17 14:19:19 absol pppd[4848]: pppd 2.4.4 started by root, uid 0 Dec 17 14:19:19 absol pppd[4848]: using channel 1 Dec 17 14:19:19 absol pppd[4848]: Using interface ppp0 Dec 17 14:19:19 absol pppd[4848]: Connect: ppp0 <--> 8.48
Best regards, Nicolas Kaiser
| |