lkml.org 
[lkml]   [2010]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Stable-review] [20/98] atl1c:use common_task instead of reset_task and link_chg_task
    Willy Tarreau wrote:
    > On Tue, Jan 26, 2010 at 03:33:46PM -0800, Greg KH wrote:
    >> From: Jie Yang <jie.yang@atheros.com>
    >>
    >> commit cb19054697e92a793f336380fd72c588521178ff upstream.
    >>
    >> use common_task instead of reset_task and link_chg_task, so it fix "call cancel_work_sync
    >> from the work itself".
    >>
    >> Signed-off-by: Jie Yang <jie.yang@atheros.com>
    >> Signed-off-by: David S. Miller <davem@davemloft.net>
    >> Cc: Ben Hutchings <ben@decadent.org.uk>
    >> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    >
    > I'm going to test this one. I'm randomly seeing my ASUS 1005HA
    > hanging after I replug the network cable. I noticed that the
    > driver from the Atheros site doesn't have the issue at all. I
    > spent a week-end trying to eliminate almost all of the diffs
    > between the two drivers to try to spot the faulty code chunk,
    > until I realized that I went past the failure point without
    > noticing in time because the issue was too much random :-(

    Not sure how much this is true or helps. While looking over that patch I was
    wondering whether there could be a problem of not having an explicit
    cancel_work_sync on the way down. It just seems to disable actions by setting
    the flags to 0 but I somehow it felt like it still could be scheduled to run
    doing nothing...

    -Stefan
    > Clearly a non-bisectable issue. But with just this fix, I'll
    > be able to tell if the problem is definitely over.
    >
    > Regards,
    > Willy
    >
    > _______________________________________________
    > Stable-review mailing list
    > Stable-review@linux.kernel.org
    > http://linux.kernel.org/mailman/listinfo/stable-review



    \
     
     \ /
      Last update: 2010-01-27 15:47    [W:0.047 / U:0.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site