lkml.org 
[lkml]   [2010]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[77/98] netiucv: displayed TX bytes value much too high
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Ursula Braun <ursula.braun@de.ibm.com>

    commit 998221c26b86a7edd621e66b437628c5ec0f8e9b upstream.

    tx_bytes value must be updated by skb length before skb is freed.

    Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Acked-by: John Jolly <jjolly@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/s390/net/netiucv.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/s390/net/netiucv.c
    +++ b/drivers/s390/net/netiucv.c
    @@ -741,13 +741,13 @@ static void conn_action_txdone(fsm_insta
    if (single_flag) {
    if ((skb = skb_dequeue(&conn->commit_queue))) {
    atomic_dec(&skb->users);
    - dev_kfree_skb_any(skb);
    if (privptr) {
    privptr->stats.tx_packets++;
    privptr->stats.tx_bytes +=
    (skb->len - NETIUCV_HDRLEN
    - - NETIUCV_HDRLEN);
    + - NETIUCV_HDRLEN);
    }
    + dev_kfree_skb_any(skb);
    }
    }
    conn->tx_buff->data = conn->tx_buff->head;



    \
     
     \ /
      Last update: 2010-01-27 00:53    [W:0.019 / U:118.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site