lkml.org 
[lkml]   [2010]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[41/98] [SCSI] libfc: fix typo in retry check on received PRLI
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Joe Eykholt <jeykholt@cisco.com>

    commit 85b5893ca97c69e409ecbb5ee90a5d99882369c4 upstream.

    A received Fibre Channel ELS PRLI request contains a bit that
    indicates whether the remote port supports certain retry processing
    sequences. The test for this bit was somehow coded to use multiply
    instead of AND!

    This case would apply only for target mode operation, and it is
    unlikely to be noticed as an initiator.

    Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
    Signed-off-by: Robert Love <robert.w.love@intel.com>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/libfc/fc_rport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/libfc/fc_rport.c
    +++ b/drivers/scsi/libfc/fc_rport.c
    @@ -1402,7 +1402,7 @@ static void fc_rport_recv_prli_req(struc
    break;
    case FC_TYPE_FCP:
    fcp_parm = ntohl(rspp->spp_params);
    - if (fcp_parm * FCP_SPPF_RETRY)
    + if (fcp_parm & FCP_SPPF_RETRY)
    rdata->flags |= FC_RP_FLAGS_RETRY;
    rdata->supported_classes = FC_COS_CLASS3;
    if (fcp_parm & FCP_SPPF_INIT_FCN)



    \
     
     \ /
      Last update: 2010-01-27 01:01    [W:3.561 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site