Messages in this thread | | | Date | Tue, 15 Sep 2009 23:22:34 -0300 | From | Henrique de Moraes Holschuh <> | Subject | Re: [PATCH 1/3] backlight: Provide two stage registration |
| |
On Tue, 15 Sep 2009, Matthew Garrett wrote: > On Tue, Sep 15, 2009 at 08:18:42PM +0100, Richard Purdie wrote: > > Could we not pass an optional pointer to a properties structure to > > create the backlight with instead or find a better way to solve this? > > That'd work, but it'd involve significant refactoring of all the > drivers - we really need to be setting max_brightness before > device_register() is called. I suspect it'd be an even larger delta > against mainline.
rfkill has taught us that if you have parameters that MUST be properly set, they should be required parameters for the foo_register() call...
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
| |