Messages in this thread | | | Subject | Re: [PATCH 1/3] backlight: Provide two stage registration | From | Richard Purdie <> | Date | Tue, 15 Sep 2009 20:18:42 +0100 |
| |
On Tue, 2009-09-15 at 17:19 +0100, Matthew Garrett wrote: > The backlight class currently allocates and registers a backlight device > in a single function, making it impossible for certain backlight parameters > to be set before the device becomes visible to userspace. This can cause > problems if userspace wins the race and manages to read any of these values > before they've been set, and also makes it harder to extend information > that we may wish to provide to the rest of the kernel at registration time. > > This patch breaks the register and unregister functions into two, > separating allocation and registration. The old functions are left to ease > transition.
I understand the problem but the second patch in this series bothers me - an additional 300 lines of error handling in each driver.
Could we not pass an optional pointer to a properties structure to create the backlight with instead or find a better way to solve this?
Cheers,
Richard
-- Richard Purdie Intel Open Source Technology Centre
| |