lkml.org 
[lkml]   [2009]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] backlight: Provide two stage registration
From
Date
On Tue, 2009-09-15 at 20:27 +0100, Matthew Garrett wrote:
> On Tue, Sep 15, 2009 at 08:18:42PM +0100, Richard Purdie wrote:
>
> > Could we not pass an optional pointer to a properties structure to
> > create the backlight with instead or find a better way to solve this?
>
> That'd work, but it'd involve significant refactoring of all the
> drivers - we really need to be setting max_brightness before
> device_register() is called. I suspect it'd be an even larger delta
> against mainline.

But the delta would result in more readable code rather than all that
error checking/handling. Can we see how ugly that diff turns out to be?

Cheers,

Richard

--
Richard Purdie
Intel Open Source Technology Centre



\
 
 \ /
  Last update: 2009-09-15 21:49    [W:0.047 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site