Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] ata: libata depends on HAS_DMA | Date | Fri, 15 May 2009 13:16:30 +0200 |
| |
On Friday 15 May 2009, Tejun Heo wrote: > FUJITA Tomonori wrote: > > Can libata call dma_supported() per device to decide DMA or PIO mode? > > Then, we can solve this problem by add dummy DMA API (just calls BUG) > > on such architectures, without Kconfig magic or adding ifdef (like the > > old ide stack does), I think.
That would be the !CONFIG_PCI half of the old include/asm-generic/dma-mapping.h file that you just removed, right?
In general, I'd prefer keeping the asm-generic/dma-mapping-broken.h implementation that gives us a compile-time error, but maybe there is an even better option based on the mn10300 implementation which basically pretends everything works with just page_to_phys() mappings.
> Sure it can. Which specific drivers are we talking about?
The main problem is libata-core.c, which references DMA mapping API calls that are only implemented on architectures setting CONFIG_HAS_DMA.
Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |